Expand long running timer functionality to WaitForExternalEvent #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally WaitForExternalEvent with a timeout uses a timer. In v2.3.0 we added support for long-running timers, we just didn't remove the now unecessary validation from the WaitForExternalEvent API. This PR validates the scenario with a test and removes this validation. Note that initially this PR attempted to expand this functionality to RetryOptions in CallActivity/SubOrchestrationWithRetry, but unfortunately the timer used by that retry is lower level than the Durable Functions layer, meaning we can't use our long-running support. Addresses #1538
davidmrdavid
reviewed
Nov 5, 2020
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableOrchestrationContext.cs
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/Listener/OutOfProcOrchestrationShim.cs
Outdated
Show resolved
Hide resolved
davidmrdavid
approved these changes
Nov 6, 2020
|
|
||
| private bool ValidOutOfProcTimer(DateTime fireAt, out string errorMessage) | ||
| // We now have built in long-timer support for C#, but in some scenarios, such as out-of-proc, | ||
| // we may still need to enforce this limitations until the solution works there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally WaitForExternalEvent with a timeout uses a timer. In v2.3.0
we added support for long-running timers, we just didn't remove the
now unecessary validation from the WaitForExternalEvent API. This PR
validates the scenario with a test and removes this validation.
Note that initially this PR attempted to expand this functionality to
RetryOptions in CallActivity/SubOrchestrationWithRetry, but
unfortunately the timer used by that retry is lower level than the
Durable Functions layer, meaning we can't use our long-running support.
Addresses #1538